Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2340)

Unified Diff: content/renderer/p2p/network_manager_uma.h

Issue 1349823004: Check media permissions (mic/camera) before exposing local addresses to WebRTC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/p2p/network_manager_uma.h
diff --git a/content/renderer/p2p/network_manager_uma.h b/content/renderer/p2p/network_manager_uma.h
new file mode 100644
index 0000000000000000000000000000000000000000..a4382f1c2a254a88af374fa4fcd0a930cfef40c3
--- /dev/null
+++ b/content/renderer/p2p/network_manager_uma.h
@@ -0,0 +1,28 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_RENDERER_P2P_NETWORK_MANAGER_UMA_H_
+#define CONTENT_RENDERER_P2P_NETWORK_MANAGER_UMA_H_
+
+namespace base {
+class TimeDelta;
+} // namespace
+
+namespace content {
+
+// Need to be kept the same order as in histograms.xml
+enum IPPermissionStatus {
Sergey Ulanov 2015/09/24 19:37:29 I'm not sure it's worth adding an extra file just
guoweis_left_chromium 2015/09/24 23:06:01 I need this in both EmptyNetworkManager as well as
Sergey Ulanov 2015/09/25 00:45:30 Yes, my suggestion was to include filtering_networ
+ PERMISSION_NOT_REQUESTED, // Multiple routes is not requested.
+ PERMISSION_DENIED, // Requested but denied.
+ PERMISSION_GRANTED, // Requested and granted.
+ PERMISSION_UNKNOWN, // Requested but have never fired SignalNetworksChanged.
+ PERMISSION_MAX,
+};
+
+void ReportIPPermissionStatus(IPPermissionStatus status);
+void ReportTimeToUpdateNetwork(const base::TimeDelta& ticks);
Sergey Ulanov 2015/09/24 19:37:29 maybe calle it ReportTimeToUpdateNetworkList()
guoweis_left_chromium 2015/09/24 23:06:01 Done.
+
+} // namespace content
+
+#endif // CONTENT_RENDERER_P2P_NETWORK_MANAGER_UMA_H_

Powered by Google App Engine
This is Rietveld 408576698