Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: content/renderer/p2p/network_manager_uma.h

Issue 1349823004: Check media permissions (mic/camera) before exposing local addresses to WebRTC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_RENDERER_P2P_NETWORK_MANAGER_UMA_H_
6 #define CONTENT_RENDERER_P2P_NETWORK_MANAGER_UMA_H_
7
8 namespace base {
9 class TimeDelta;
10 } // namespace
11
12 namespace content {
13
14 // Need to be kept the same order as in histograms.xml
15 enum IPPermissionStatus {
Sergey Ulanov 2015/09/24 19:37:29 I'm not sure it's worth adding an extra file just
guoweis_left_chromium 2015/09/24 23:06:01 I need this in both EmptyNetworkManager as well as
Sergey Ulanov 2015/09/25 00:45:30 Yes, my suggestion was to include filtering_networ
16 PERMISSION_NOT_REQUESTED, // Multiple routes is not requested.
17 PERMISSION_DENIED, // Requested but denied.
18 PERMISSION_GRANTED, // Requested and granted.
19 PERMISSION_UNKNOWN, // Requested but have never fired SignalNetworksChanged.
20 PERMISSION_MAX,
21 };
22
23 void ReportIPPermissionStatus(IPPermissionStatus status);
24 void ReportTimeToUpdateNetwork(const base::TimeDelta& ticks);
Sergey Ulanov 2015/09/24 19:37:29 maybe calle it ReportTimeToUpdateNetworkList()
guoweis_left_chromium 2015/09/24 23:06:01 Done.
25
26 } // namespace content
27
28 #endif // CONTENT_RENDERER_P2P_NETWORK_MANAGER_UMA_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698