Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: ui/accessibility/ax_node_data.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/accessibility/ax_node_data.h
diff --git a/ui/accessibility/ax_node_data.h b/ui/accessibility/ax_node_data.h
index 528b27b71325244727fc720639088614cc4d5cc2..9b517b16b50304527e251181f16c9243dfd7b6d4 100644
--- a/ui/accessibility/ax_node_data.h
+++ b/ui/accessibility/ax_node_data.h
@@ -82,9 +82,9 @@ struct AX_EXPORT AXNodeData {
// Convenience functions, mainly for writing unit tests.
// Equivalent to AddStringAttribute(ATTR_NAME, name).
- void SetName(std::string name);
+ void SetName(const std::string& name);
// Equivalent to AddStringAttribute(ATTR_VALUE, value).
- void SetValue(std::string value);
+ void SetValue(const std::string& value);
// Return a string representation of this data, for debugging.
virtual std::string ToString() const;
« no previous file with comments | « tools/gn/value.cc ('k') | ui/accessibility/ax_node_data.cc » ('j') | url/gurl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698