Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: ui/accessibility/ax_node_data.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/accessibility/ax_node_data.cc
diff --git a/ui/accessibility/ax_node_data.cc b/ui/accessibility/ax_node_data.cc
index 262e19253f376cc30f2350e1e0d727974901c69a..7f0829824b16d4656b87344e01e282c7f004aba2 100644
--- a/ui/accessibility/ax_node_data.cc
+++ b/ui/accessibility/ax_node_data.cc
@@ -244,11 +244,11 @@ void AXNodeData::AddIntListAttribute(
intlist_attributes.push_back(std::make_pair(attribute, value));
}
-void AXNodeData::SetName(std::string name) {
+void AXNodeData::SetName(const std::string& name) {
string_attributes.push_back(std::make_pair(AX_ATTR_NAME, name));
}
-void AXNodeData::SetValue(std::string value) {
+void AXNodeData::SetValue(const std::string& value) {
string_attributes.push_back(std::make_pair(AX_ATTR_VALUE, value));
}
« no previous file with comments | « ui/accessibility/ax_node_data.h ('k') | ui/compositor/layer.cc » ('j') | url/gurl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698