Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sync/test/fake_server/fake_server_entity.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/test/fake_server/bookmark_entity.cc ('k') | sync/test/fake_server/fake_server_entity.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/test/fake_server/fake_server_entity.h
diff --git a/sync/test/fake_server/fake_server_entity.h b/sync/test/fake_server/fake_server_entity.h
index ed120969b5ad0730161b7c07f1f7120944cc0d0f..a1316d189ec8cb70162fa91f8dda7d79125e5c11 100644
--- a/sync/test/fake_server/fake_server_entity.h
+++ b/sync/test/fake_server/fake_server_entity.h
@@ -35,7 +35,7 @@ class FakeServerEntity {
int64 GetVersion() const;
void SetVersion(int64 version);
const std::string& GetName() const;
- void SetName(std::string name);
+ void SetName(const std::string& name);
// Replaces |specifics_| with |updated_specifics|. This method is meant to be
// used to mimic a client commit.
« no previous file with comments | « sync/test/fake_server/bookmark_entity.cc ('k') | sync/test/fake_server/fake_server_entity.cc » ('j') | url/gurl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698