sync/test/fake_server/fake_server_entity.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/test/fake_server/fake_server_entity.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/test/fake_server/fake_server_entity.cc

diff --git a/sync/test/fake_server/fake_server_entity.cc b/sync/test/fake_server/fake_server_entity.cc

index 9d7f6baebf4ff4ff9bb3388546cafeb411696dfb..e76daa7bc6f918c09eeb37d9ac3594dba08f4217 100644

--- a/sync/test/fake_server/fake_server_entity.cc

+++ b/sync/test/fake_server/fake_server_entity.cc

@@ -58,7 +58,7 @@ const std::string& FakeServerEntity::GetName() const {

return name_;

}

-void FakeServerEntity::SetName(std::string name) {

+void FakeServerEntity::SetName(const std::string& name) {

name_ = name;

}

« no previous file with comments | « sync/test/fake_server/fake_server_entity.h ('k') | sync/util/cryptographer.h » ('j') | url/gurl.h » ('J')