Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Unified Diff: sync/internal_api/sync_manager_factory.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/sync_manager_factory.cc
diff --git a/sync/internal_api/sync_manager_factory.cc b/sync/internal_api/sync_manager_factory.cc
index c3f09d32e5b09f3e7eb1cffd3511d804339636d4..288b5dad45f482fe6a66add540671b5bfba9bcc0 100644
--- a/sync/internal_api/sync_manager_factory.cc
+++ b/sync/internal_api/sync_manager_factory.cc
@@ -18,7 +18,7 @@ SyncManagerFactory::~SyncManagerFactory() {
}
scoped_ptr<SyncManager> SyncManagerFactory::CreateSyncManager(
- const std::string name) {
+ const std::string& name) {
switch (type_) {
case NORMAL:
return scoped_ptr<SyncManager>(new SyncManagerImpl(name));

Powered by Google App Engine
This is Rietveld 408576698