Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: sync/internal_api/sync_manager_factory.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/internal_api/public/sync_manager_factory.h" 5 #include "sync/internal_api/public/sync_manager_factory.h"
6 6
7 #include "sync/internal_api/sync_backup_manager.h" 7 #include "sync/internal_api/sync_backup_manager.h"
8 #include "sync/internal_api/sync_manager_impl.h" 8 #include "sync/internal_api/sync_manager_impl.h"
9 #include "sync/internal_api/sync_rollback_manager.h" 9 #include "sync/internal_api/sync_rollback_manager.h"
10 10
11 namespace syncer { 11 namespace syncer {
12 12
13 SyncManagerFactory::SyncManagerFactory(SyncManagerFactory::MANAGER_TYPE type) 13 SyncManagerFactory::SyncManagerFactory(SyncManagerFactory::MANAGER_TYPE type)
14 : type_(type) { 14 : type_(type) {
15 } 15 }
16 16
17 SyncManagerFactory::~SyncManagerFactory() { 17 SyncManagerFactory::~SyncManagerFactory() {
18 } 18 }
19 19
20 scoped_ptr<SyncManager> SyncManagerFactory::CreateSyncManager( 20 scoped_ptr<SyncManager> SyncManagerFactory::CreateSyncManager(
21 const std::string name) { 21 const std::string& name) {
22 switch (type_) { 22 switch (type_) {
23 case NORMAL: 23 case NORMAL:
24 return scoped_ptr<SyncManager>(new SyncManagerImpl(name)); 24 return scoped_ptr<SyncManager>(new SyncManagerImpl(name));
25 case BACKUP: 25 case BACKUP:
26 return scoped_ptr<SyncManager>(new SyncBackupManager()); 26 return scoped_ptr<SyncManager>(new SyncBackupManager());
27 case ROLLBACK: 27 case ROLLBACK:
28 return scoped_ptr<SyncManager>(new SyncRollbackManager()); 28 return scoped_ptr<SyncManager>(new SyncRollbackManager());
29 default: 29 default:
30 NOTREACHED(); 30 NOTREACHED();
31 return scoped_ptr<SyncManager>(new SyncManagerImpl(name)); 31 return scoped_ptr<SyncManager>(new SyncManagerImpl(name));
32 } 32 }
33 } 33 }
34 34
35 } // namespace syncer 35 } // namespace syncer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698