Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: sync/internal_api/public/test/sync_manager_factory_for_profile_sync_test.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/public/test/sync_manager_factory_for_profile_sync_test.h
diff --git a/sync/internal_api/public/test/sync_manager_factory_for_profile_sync_test.h b/sync/internal_api/public/test/sync_manager_factory_for_profile_sync_test.h
index 695d07e73dee5549ec7543b81ee492d175717371..8eb053f2ae79c58ae1523dab3f24ba3599bfb3f5 100644
--- a/sync/internal_api/public/test/sync_manager_factory_for_profile_sync_test.h
+++ b/sync/internal_api/public/test/sync_manager_factory_for_profile_sync_test.h
@@ -17,7 +17,8 @@ class SyncManagerFactoryForProfileSyncTest : public syncer::SyncManagerFactory {
public:
SyncManagerFactoryForProfileSyncTest(base::Closure init_callback);
~SyncManagerFactoryForProfileSyncTest() override;
- scoped_ptr<syncer::SyncManager> CreateSyncManager(std::string name) override;
+ scoped_ptr<syncer::SyncManager> CreateSyncManager(
+ const std::string& name) override;
private:
base::Closure init_callback_;

Powered by Google App Engine
This is Rietveld 408576698