Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sync/internal_api/public/sync_manager_factory.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « rlz/chromeos/lib/rlz_value_store_chromeos.cc ('k') | sync/internal_api/public/test/sync_manager_factory_for_profile_sync_test.h » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/public/sync_manager_factory.h
diff --git a/sync/internal_api/public/sync_manager_factory.h b/sync/internal_api/public/sync_manager_factory.h
index a121c8bf1f720b16c13d4dfd6572dbfca39c33bf..e38afb100d14dc449a79e55e669593dac181bd19 100644
--- a/sync/internal_api/public/sync_manager_factory.h
+++ b/sync/internal_api/public/sync_manager_factory.h
@@ -26,7 +26,7 @@ class SYNC_EXPORT SyncManagerFactory {
SyncManagerFactory(MANAGER_TYPE type);
virtual ~SyncManagerFactory();
- virtual scoped_ptr<SyncManager> CreateSyncManager(std::string name);
+ virtual scoped_ptr<SyncManager> CreateSyncManager(const std::string& name);
private:
MANAGER_TYPE type_;
« no previous file with comments | « rlz/chromeos/lib/rlz_value_store_chromeos.cc ('k') | sync/internal_api/public/test/sync_manager_factory_for_profile_sync_test.h » ('j') | url/gurl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698