net/tools/tld_cleanup/tld_cleanup_util_unittest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/tld_cleanup/tld_cleanup_util_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/tld_cleanup/tld_cleanup_util_unittest.cc

diff --git a/net/tools/tld_cleanup/tld_cleanup_util_unittest.cc b/net/tools/tld_cleanup/tld_cleanup_util_unittest.cc

index 6c7cbad918079523deaf93e534a8fdb374c0f3d5..d2b970e71f8db4f831d0b6da0d1ab1629a1c8acc 100644

--- a/net/tools/tld_cleanup/tld_cleanup_util_unittest.cc

+++ b/net/tools/tld_cleanup/tld_cleanup_util_unittest.cc

@@ -10,7 +10,8 @@

namespace net {

namespace tld_cleanup {

-std::string SetupData(std::string icann_domains, std::string private_domains) {

+std::string SetupData(const std::string& icann_domains,

+ const std::string& private_domains) {

return "// ===BEGIN ICANN DOMAINS===\n" +

icann_domains +

"// ===END ICANN DOMAINS===\n" +

« no previous file with comments | « net/tools/quic/test_tools/quic_test_client.cc ('k') | net/udp/udp_socket_perftest.cc » ('j') | url/gurl.h » ('J')