net/tools/quic/test_tools/quic_test_client.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/test_tools/quic_test_client.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/test_tools/quic_test_client.cc

diff --git a/net/tools/quic/test_tools/quic_test_client.cc b/net/tools/quic/test_tools/quic_test_client.cc

index 1b01daadc6acf952054bd8afc7eb6566fda62a80..eff3160539f410d17bf16b1d57032e8d37b1031e 100644

--- a/net/tools/quic/test_tools/quic_test_client.cc

+++ b/net/tools/quic/test_tools/quic_test_client.cc

@@ -318,11 +318,11 @@ ssize_t QuicTestClient::SendMessage(const HTTPMessage& message) {

return ret;

}

-ssize_t QuicTestClient::SendData(string data, bool last_data) {

+ssize_t QuicTestClient::SendData(const string& data, bool last_data) {

return SendData(data, last_data, nullptr);

}

-ssize_t QuicTestClient::SendData(string data,

+ssize_t QuicTestClient::SendData(const string& data,

bool last_data,

QuicAckNotifier::DelegateInterface* delegate) {

return GetOrCreateStreamAndSendRequest(nullptr, StringPiece(data), last_data,

« no previous file with comments | « net/tools/quic/test_tools/quic_test_client.h ('k') | net/tools/tld_cleanup/tld_cleanup_util_unittest.cc » ('j') | url/gurl.h » ('J')