net/quic/quic_stream_sequencer.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_stream_sequencer.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_stream_sequencer.cc

diff --git a/net/quic/quic_stream_sequencer.cc b/net/quic/quic_stream_sequencer.cc

index acddefd39ee95f6997eb93998842947a0080b917..bd1bc6e40032335efa87d084428c4aedd87f26fa 100644

--- a/net/quic/quic_stream_sequencer.cc

+++ b/net/quic/quic_stream_sequencer.cc

@@ -18,7 +18,7 @@ using std::string;

namespace net {

QuicStreamSequencer::FrameData::FrameData(QuicStreamOffset offset,

- string segment)

+ const string& segment)

: offset(offset), segment(segment) {}

QuicStreamSequencer::QuicStreamSequencer(ReliableQuicStream* quic_stream)

« no previous file with comments | « net/quic/quic_stream_sequencer.h ('k') | net/socket/tcp_server_socket_unittest.cc » ('j') | url/gurl.h » ('J')