Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: net/quic/quic_stream_sequencer.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_stream_sequencer.h" 5 #include "net/quic/quic_stream_sequencer.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 #include <utility> 9 #include <utility>
10 10
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "net/quic/reliable_quic_stream.h" 12 #include "net/quic/reliable_quic_stream.h"
13 13
14 using std::min; 14 using std::min;
15 using std::numeric_limits; 15 using std::numeric_limits;
16 using std::string; 16 using std::string;
17 17
18 namespace net { 18 namespace net {
19 19
20 QuicStreamSequencer::FrameData::FrameData(QuicStreamOffset offset, 20 QuicStreamSequencer::FrameData::FrameData(QuicStreamOffset offset,
21 string segment) 21 const string& segment)
22 : offset(offset), segment(segment) {} 22 : offset(offset), segment(segment) {}
23 23
24 QuicStreamSequencer::QuicStreamSequencer(ReliableQuicStream* quic_stream) 24 QuicStreamSequencer::QuicStreamSequencer(ReliableQuicStream* quic_stream)
25 : stream_(quic_stream), 25 : stream_(quic_stream),
26 num_bytes_consumed_(0), 26 num_bytes_consumed_(0),
27 close_offset_(numeric_limits<QuicStreamOffset>::max()), 27 close_offset_(numeric_limits<QuicStreamOffset>::max()),
28 blocked_(false), 28 blocked_(false),
29 num_bytes_buffered_(0), 29 num_bytes_buffered_(0),
30 num_frames_received_(0), 30 num_frames_received_(0),
31 num_duplicate_frames_received_(0), 31 num_duplicate_frames_received_(0),
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 } 289 }
290 290
291 void QuicStreamSequencer::RecordBytesConsumed(size_t bytes_consumed) { 291 void QuicStreamSequencer::RecordBytesConsumed(size_t bytes_consumed) {
292 num_bytes_consumed_ += bytes_consumed; 292 num_bytes_consumed_ += bytes_consumed;
293 num_bytes_buffered_ -= bytes_consumed; 293 num_bytes_buffered_ -= bytes_consumed;
294 294
295 stream_->AddBytesConsumed(bytes_consumed); 295 stream_->AddBytesConsumed(bytes_consumed);
296 } 296 }
297 297
298 } // namespace net 298 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698