net/cookies/cookie_monster_unittest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cookies/cookie_monster_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cookies/cookie_monster_unittest.cc

diff --git a/net/cookies/cookie_monster_unittest.cc b/net/cookies/cookie_monster_unittest.cc

index 173eced5d7c1d08f1f15148f7df47d14378358f9..c4df76558d7ccde4f6d40add0a4cbfca65bdbc51 100644

--- a/net/cookies/cookie_monster_unittest.cc

+++ b/net/cookies/cookie_monster_unittest.cc

@@ -778,7 +778,7 @@ class DeferredCookieTaskTest : public CookieMonsterTest {

// Declares an expectation that PersistentCookieStore::LoadCookiesForKey

// will be called, saving the provided callback and sending a quit to the

// message loop.

- void ExpectLoadForKeyCall(std::string key, bool quit_queue) {

+ void ExpectLoadForKeyCall(const std::string& key, bool quit_queue) {

if (quit_queue)

EXPECT_CALL(*persistent_store_.get(), LoadCookiesForKey(key, testing::_))

.WillOnce(

« no previous file with comments | « net/cert/multi_log_ct_verifier_unittest.cc ('k') | net/dns/mdns_client_impl.h » ('j') | url/gurl.h » ('J')