Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: net/cert/multi_log_ct_verifier_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/multi_log_ct_verifier_unittest.cc
diff --git a/net/cert/multi_log_ct_verifier_unittest.cc b/net/cert/multi_log_ct_verifier_unittest.cc
index a994eb218f25131163a439493a446e0b159c98be..492c21a06d496921d48025bd1f5e940db6004b6a 100644
--- a/net/cert/multi_log_ct_verifier_unittest.cc
+++ b/net/cert/multi_log_ct_verifier_unittest.cc
@@ -176,7 +176,8 @@ class MultiLogCTVerifierTest : public ::testing::Test {
}
// Histogram-related helper methods
- int GetValueFromHistogram(std::string histogram_name, int sample_index) {
+ int GetValueFromHistogram(const std::string& histogram_name,
+ int sample_index) {
base::Histogram* histogram = static_cast<base::Histogram*>(
base::StatisticsRecorder::FindHistogram(histogram_name));

Powered by Google App Engine
This is Rietveld 408576698