Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gpu/tools/compositor_model_bench/render_tree.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/tools/compositor_model_bench/render_tree.h ('k') | gpu/tools/compositor_model_bench/shaders.h » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/tools/compositor_model_bench/render_tree.cc
diff --git a/gpu/tools/compositor_model_bench/render_tree.cc b/gpu/tools/compositor_model_bench/render_tree.cc
index f2369df18ef6650e4aa233a30cc1114db94cd049..e1a3804b99307004006dd508ef45beff8374b632 100644
--- a/gpu/tools/compositor_model_bench/render_tree.cc
+++ b/gpu/tools/compositor_model_bench/render_tree.cc
@@ -23,7 +23,7 @@ using base::ReadFileToString;
using std::string;
using std::vector;
-GLenum TextureFormatFromString(std::string format) {
+GLenum TextureFormatFromString(const std::string& format) {
if (format == "RGBA")
return GL_RGBA;
if (format == "RGB")
« no previous file with comments | « gpu/tools/compositor_model_bench/render_tree.h ('k') | gpu/tools/compositor_model_bench/shaders.h » ('j') | url/gurl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698