google_apis/gaia/oauth2_token_service_test_util.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/oauth2_token_service_test_util.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gaia/oauth2_token_service_test_util.h

diff --git a/google_apis/gaia/oauth2_token_service_test_util.h b/google_apis/gaia/oauth2_token_service_test_util.h

index 6a14f139bedfecafb1d2d6a44f86107ec8b96374..e3881b7ef57390fb68e6042981b116c074e03d48 100644

--- a/google_apis/gaia/oauth2_token_service_test_util.h

+++ b/google_apis/gaia/oauth2_token_service_test_util.h

@@ -10,7 +10,7 @@

#include "google_apis/gaia/google_service_auth_error.h"

#include "google_apis/gaia/oauth2_token_service.h"

-std::string GetValidTokenResponse(std::string token, int expiration);

+std::string GetValidTokenResponse(const std::string& token, int expiration);

// A simple testing consumer.

class TestingOAuth2TokenServiceConsumer : public OAuth2TokenService::Consumer {

« no previous file with comments | « google_apis/gaia/account_tracker_unittest.cc ('k') | google_apis/gaia/oauth2_token_service_test_util.cc » ('j') | url/gurl.h » ('J')