google_apis/gaia/oauth2_token_service_test_util.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/oauth2_token_service_test_util.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gaia/oauth2_token_service_test_util.cc

diff --git a/google_apis/gaia/oauth2_token_service_test_util.cc b/google_apis/gaia/oauth2_token_service_test_util.cc

index 6dbed5f8974903b75d09bc031db3db291442b396..597d61d6040f8b84a4fc7feff571abceb74eefaf 100644

--- a/google_apis/gaia/oauth2_token_service_test_util.cc

+++ b/google_apis/gaia/oauth2_token_service_test_util.cc

@@ -15,7 +15,7 @@ const char kValidTokenResponse[] =

"}";

}

-std::string GetValidTokenResponse(std::string token, int expiration) {

+std::string GetValidTokenResponse(const std::string& token, int expiration) {

return base::StringPrintf(kValidTokenResponse, token.c_str(), expiration);

}

« no previous file with comments | « google_apis/gaia/oauth2_token_service_test_util.h ('k') | google_apis/gcm/monitoring/fake_gcm_stats_recorder.h » ('j') | url/gurl.h » ('J')