google_apis/gaia/account_tracker.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/account_tracker.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gaia/account_tracker.h

diff --git a/google_apis/gaia/account_tracker.h b/google_apis/gaia/account_tracker.h

index 61d3748868bf593a70eebdf17f3c8ada3c0c55ab..653f7b7491ddec4d1c8f0e7d1f00e5347e23e175 100644

--- a/google_apis/gaia/account_tracker.h

+++ b/google_apis/gaia/account_tracker.h

@@ -97,12 +97,12 @@ class AccountTracker : public OAuth2TokenService::Observer,

void NotifyAccountRemoved(const AccountState& account);

void NotifySignInChanged(const AccountState& account);

- void UpdateSignInState(const std::string account_key, bool is_signed_in);

+ void UpdateSignInState(const std::string& account_key, bool is_signed_in);

- void StartTrackingAccount(const std::string account_key);

- void StopTrackingAccount(const std::string account_key);

+ void StartTrackingAccount(const std::string& account_key);

+ void StopTrackingAccount(const std::string& account_key);

void StopTrackingAllAccounts();

- void StartFetchingUserInfo(const std::string account_key);

+ void StartFetchingUserInfo(const std::string& account_key);

void DeleteFetcher(AccountIdFetcher* fetcher);

IdentityProvider* identity_provider_; // Not owned.

« no previous file with comments | « extensions/common/manifest_test.cc ('k') | google_apis/gaia/account_tracker.cc » ('j') | url/gurl.h » ('J')