Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: google_apis/gaia/account_tracker.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gaia/account_tracker.cc
diff --git a/google_apis/gaia/account_tracker.cc b/google_apis/gaia/account_tracker.cc
index f424863c9e8c6f9ab1d18aa73d02ac5769a2f508..d40cd20a59b0bd5d75162177953e7342c468c7a7 100644
--- a/google_apis/gaia/account_tracker.cc
+++ b/google_apis/gaia/account_tracker.cc
@@ -177,7 +177,7 @@ void AccountTracker::NotifySignInChanged(const AccountState& account) {
OnAccountSignInChanged(account.ids, account.is_signed_in));
}
-void AccountTracker::UpdateSignInState(const std::string account_key,
+void AccountTracker::UpdateSignInState(const std::string& account_key,
bool is_signed_in) {
// TODO(robliao): Remove ScopedTracker below once https://crbug.com/422460 is
// fixed.
@@ -198,7 +198,7 @@ void AccountTracker::UpdateSignInState(const std::string account_key,
NotifySignInChanged(account);
}
-void AccountTracker::StartTrackingAccount(const std::string account_key) {
+void AccountTracker::StartTrackingAccount(const std::string& account_key) {
// TODO(robliao): Remove ScopedTracker below once https://crbug.com/422460 is
// fixed.
tracked_objects::ScopedTracker tracking_profile(
@@ -215,7 +215,7 @@ void AccountTracker::StartTrackingAccount(const std::string account_key) {
}
}
-void AccountTracker::StopTrackingAccount(const std::string account_key) {
+void AccountTracker::StopTrackingAccount(const std::string& account_key) {
DVLOG(1) << "StopTracking " << account_key;
if (ContainsKey(accounts_, account_key)) {
AccountState& account = accounts_[account_key];
@@ -235,7 +235,7 @@ void AccountTracker::StopTrackingAllAccounts() {
StopTrackingAccount(accounts_.begin()->first);
}
-void AccountTracker::StartFetchingUserInfo(const std::string account_key) {
+void AccountTracker::StartFetchingUserInfo(const std::string& account_key) {
// TODO(robliao): Remove ScopedTracker below once https://crbug.com/422460 is
// fixed.
tracked_objects::ScopedTracker tracking_profile(

Powered by Google App Engine
This is Rietveld 408576698