Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: extensions/common/manifest_test.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_test.h
diff --git a/extensions/common/manifest_test.h b/extensions/common/manifest_test.h
index cf416ce6160d27d1a90dc146020249d6b50d9ffe..a396b97a853bba00efe4a7c8737edc6e5926a806 100644
--- a/extensions/common/manifest_test.h
+++ b/extensions/common/manifest_test.h
@@ -130,19 +130,22 @@ class ManifestTest : public testing::Test {
};
struct Testcase {
- std::string manifest_filename_;
+ const std::string manifest_filename_;
std::string expected_error_; // only used for ExpectedError tests
extensions::Manifest::Location location_;
int flags_;
- Testcase(std::string manifest_filename, std::string expected_error,
- extensions::Manifest::Location location, int flags);
+ Testcase(const std::string& manifest_filename,
+ const std::string& expected_error,
+ extensions::Manifest::Location location,
+ int flags);
- Testcase(std::string manifest_filename, std::string expected_error);
+ Testcase(const std::string& manifest_filename,
+ const std::string& expected_error);
- explicit Testcase(std::string manifest_filename);
+ explicit Testcase(const std::string& manifest_filename);
- Testcase(std::string manifest_filename,
+ Testcase(const std::string& manifest_filename,
extensions::Manifest::Location location,
int flags);
};

Powered by Google App Engine
This is Rietveld 408576698