Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: extensions/browser/guest_view/web_view/web_view_renderer_state.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_renderer_state.h
diff --git a/extensions/browser/guest_view/web_view/web_view_renderer_state.h b/extensions/browser/guest_view/web_view/web_view_renderer_state.h
index ad2de379278fc7025c4afc32afda60a274c00855..7ee5ace4ab08dbf0bed020a29e71f3f1051adda8 100644
--- a/extensions/browser/guest_view/web_view/web_view_renderer_state.h
+++ b/extensions/browser/guest_view/web_view/web_view_renderer_state.h
@@ -81,9 +81,8 @@ class WebViewRendererState {
int web_view_count;
std::string partition_id;
WebViewPartitionInfo() {}
- WebViewPartitionInfo(int count, std::string partition):
- web_view_count(count),
- partition_id(partition) {}
+ WebViewPartitionInfo(int count, const std::string& partition)
+ : web_view_count(count), partition_id(partition) {}
};
using WebViewPartitionIDMap = std::map<int, WebViewPartitionInfo>;

Powered by Google App Engine
This is Rietveld 408576698