extensions/browser/api/networking_config/networking_config_service.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_config/networking_config_service.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative/rules_registry_service.h ('k') | extensions/browser/api/networking_config/networking_config_service.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_config/networking_config_service.h

diff --git a/extensions/browser/api/networking_config/networking_config_service.h b/extensions/browser/api/networking_config/networking_config_service.h

index 41cc15a94b937a26ced9cf393edee53736c00ce6..fae6c68fe7ee5f67b9c519c388641f2b2fde5571 100644

--- a/extensions/browser/api/networking_config/networking_config_service.h

+++ b/extensions/browser/api/networking_config/networking_config_service.h

@@ -70,7 +70,7 @@ class NetworkingConfigService : public ExtensionRegistryObserver,

// Returns true if the extension with id |extension_id| registered for

// |onCaptivePortalDetected| events, otherwise false.

- bool IsRegisteredForCaptivePortalEvent(std::string extension_id) const;

+ bool IsRegisteredForCaptivePortalEvent(const std::string& extension_id) const;

// Registers |hex_ssid| as being handled by the extension with extension ID

// |extension_id|. Returns true on success and false if another extension