Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: extensions/browser/api/declarative/rules_registry_service.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/declarative/rules_registry_service.h
diff --git a/extensions/browser/api/declarative/rules_registry_service.h b/extensions/browser/api/declarative/rules_registry_service.h
index 8f16cb2a530ea7778fce779fe6049da72e6ebc24..c00ce5749c4d2f37213dc0fa5950736d802229ea 100644
--- a/extensions/browser/api/declarative/rules_registry_service.h
+++ b/extensions/browser/api/declarative/rules_registry_service.h
@@ -40,9 +40,8 @@ class RulesRegistryService : public BrowserContextKeyedAPI,
struct RulesRegistryKey {
std::string event_name;
int rules_registry_id;
- RulesRegistryKey(const std::string event_name, int rules_registry_id)
- : event_name(event_name),
- rules_registry_id(rules_registry_id) {}
+ RulesRegistryKey(const std::string& event_name, int rules_registry_id)
+ : event_name(event_name), rules_registry_id(rules_registry_id) {}
bool operator<(const RulesRegistryKey& other) const {
return (event_name < other.event_name) ||
((event_name == other.event_name) &&

Powered by Google App Engine
This is Rietveld 408576698