content/public/test/content_browser_test_utils.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/content_browser_test_utils.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/test/content_browser_test_utils.h

diff --git a/content/public/test/content_browser_test_utils.h b/content/public/test/content_browser_test_utils.h

index 77d537c473af7d7e64abceba35a6e9799fd634e3..68ece15345a0639809ad76aa35db3d4d7c7ebfb9 100644

--- a/content/public/test/content_browser_test_utils.h

+++ b/content/public/test/content_browser_test_utils.h

@@ -50,7 +50,7 @@ bool NavigateToURL(Shell* window, const GURL& url);

void LoadDataWithBaseURL(Shell* window,

const GURL& url,

- const std::string data,

+ const std::string& data,

const GURL& base_url);

// Navigates |window| to |url|, blocking until the given number of navigations

« no previous file with comments | « content/public/browser/download_url_parameters.h ('k') | content/public/test/content_browser_test_utils.cc » ('j') | url/gurl.h » ('J')