Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: content/public/browser/download_url_parameters.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/download_url_parameters.h
diff --git a/content/public/browser/download_url_parameters.h b/content/public/browser/download_url_parameters.h
index 275088d07f735e65c768b3eb416a5f759a00ca3c..bd7af54a8c94aecc171080f6a714fb30c8761ca5 100644
--- a/content/public/browser/download_url_parameters.h
+++ b/content/public/browser/download_url_parameters.h
@@ -95,7 +95,7 @@ class CONTENT_EXPORT DownloadUrlParameters {
save_info_.suggested_name = suggested_name;
}
void set_offset(int64 offset) { save_info_.offset = offset; }
- void set_hash_state(std::string hash_state) {
+ void set_hash_state(const std::string& hash_state) {
save_info_.hash_state = hash_state;
}
void set_prompt(bool prompt) { save_info_.prompt_for_save_location = prompt; }

Powered by Google App Engine
This is Rietveld 408576698