Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1628)

Unified Diff: content/public/test/content_browser_test_utils.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/content_browser_test_utils.cc
diff --git a/content/public/test/content_browser_test_utils.cc b/content/public/test/content_browser_test_utils.cc
index d20e98e2c7f0322dfd8e0f26de5dde72ab5d6f0f..dab6f7270b64d76440f4654a9f00bc5ce2700a83 100644
--- a/content/public/test/content_browser_test_utils.cc
+++ b/content/public/test/content_browser_test_utils.cc
@@ -53,8 +53,10 @@ void ReloadBlockUntilNavigationsComplete(Shell* window,
same_tab_observer.Wait();
}
-void LoadDataWithBaseURL(Shell* window, const GURL& url,
- const std::string data, const GURL& base_url) {
+void LoadDataWithBaseURL(Shell* window,
+ const GURL& url,
+ const std::string& data,
+ const GURL& base_url) {
WaitForLoadStop(window->web_contents());
TestNavigationObserver same_tab_observer(window->web_contents(), 1);

Powered by Google App Engine
This is Rietveld 408576698