components/user_manager/user_manager_base.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/user_manager/user_manager_base.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/user_manager/user_manager_base.h

diff --git a/components/user_manager/user_manager_base.h b/components/user_manager/user_manager_base.h

index aa81f1a782aab75550ac0c08e6583409af4769cc..a89dcc1c81420dc0cb38b7787fa4b178bee5f9ba 100644

--- a/components/user_manager/user_manager_base.h

+++ b/components/user_manager/user_manager_base.h

@@ -286,10 +286,10 @@ class USER_MANAGER_EXPORT UserManagerBase : public UserManager {

virtual bool GetEphemeralUsersEnabled() const;

virtual void SetEphemeralUsersEnabled(bool enabled);

- virtual void SetOwnerEmail(std::string owner_user_id);

+ virtual void SetOwnerEmail(const std::string& owner_user_id);

virtual const std::string& GetPendingUserSwitchID() const;

- virtual void SetPendingUserSwitchID(std::string user_id);

+ virtual void SetPendingUserSwitchID(const std::string& user_id);

// The logged-in user that is currently active in current session.

// NULL until a user has logged in, then points to one

« no previous file with comments | « components/url_matcher/url_matcher_unittest.cc ('k') | components/user_manager/user_manager_base.cc » ('j') | url/gurl.h » ('J')