Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: components/user_manager/user_manager_base.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/user_manager/user_manager_base.cc
diff --git a/components/user_manager/user_manager_base.cc b/components/user_manager/user_manager_base.cc
index 4dcf5212ab23fb3a3d379221e688d1ccff452fe4..3eee72a9ee14d90c299a59527a2c76d6c278b65c 100644
--- a/components/user_manager/user_manager_base.cc
+++ b/components/user_manager/user_manager_base.cc
@@ -790,7 +790,7 @@ bool UserManagerBase::HasPendingBootstrap(const std::string& user_id) const {
return false;
}
-void UserManagerBase::SetOwnerEmail(std::string owner_user_id) {
+void UserManagerBase::SetOwnerEmail(const std::string& owner_user_id) {
owner_email_ = owner_user_id;
}
@@ -798,7 +798,7 @@ const std::string& UserManagerBase::GetPendingUserSwitchID() const {
return pending_user_switch_;
}
-void UserManagerBase::SetPendingUserSwitchID(std::string user_id) {
+void UserManagerBase::SetPendingUserSwitchID(const std::string& user_id) {
pending_user_switch_ = user_id;
}

Powered by Google App Engine
This is Rietveld 408576698