components/url_matcher/url_matcher_unittest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/url_matcher/url_matcher_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/url_matcher/url_matcher_unittest.cc

diff --git a/components/url_matcher/url_matcher_unittest.cc b/components/url_matcher/url_matcher_unittest.cc

index 328c633c311207d04610f29744eab87c61b0d791..3d6d6c5c753433cb449e1179ada8d08842b0b285 100644

--- a/components/url_matcher/url_matcher_unittest.cc

+++ b/components/url_matcher/url_matcher_unittest.cc

@@ -147,7 +147,7 @@ TEST(URLMatcherConditionTest, Comparison) {

namespace {

-bool Matches(const URLMatcherCondition& condition, std::string text) {

+bool Matches(const URLMatcherCondition& condition, const std::string& text) {

return text.find(condition.string_pattern()->pattern()) !=

std::string::npos;

}

« no previous file with comments | « components/tracing/trace_config_file.cc ('k') | components/user_manager/user_manager_base.h » ('j') | url/gurl.h » ('J')