Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: components/tracing/trace_config_file.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/tracing/trace_config_file.cc
diff --git a/components/tracing/trace_config_file.cc b/components/tracing/trace_config_file.cc
index 796eb1b7cb5dae5c923ddef43b1589cdd26eb243..769d527ca8bd5dbc2217c9ba91444b8db80aea16 100644
--- a/components/tracing/trace_config_file.cc
+++ b/components/tracing/trace_config_file.cc
@@ -87,7 +87,7 @@ TraceConfigFile::TraceConfigFile()
TraceConfigFile::~TraceConfigFile() {
}
-bool TraceConfigFile::ParseTraceConfigFileContent(std::string content) {
+bool TraceConfigFile::ParseTraceConfigFileContent(const std::string& content) {
scoped_ptr<base::Value> value(base::JSONReader::Read(content));
if (!value || !value->IsType(base::Value::TYPE_DICTIONARY))
return false;

Powered by Google App Engine
This is Rietveld 408576698