components/tracing/trace_config_file.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/trace_config_file.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/tracing/trace_config_file.h

diff --git a/components/tracing/trace_config_file.h b/components/tracing/trace_config_file.h

index 6fafda97fc3da6aa35005027888fcd68976ffdff..863fee49b5bd25d65936d17aecaa363aeb54107d 100644

--- a/components/tracing/trace_config_file.h

+++ b/components/tracing/trace_config_file.h

@@ -81,7 +81,7 @@ class TRACING_EXPORT TraceConfigFile {

TraceConfigFile();

~TraceConfigFile();

- bool ParseTraceConfigFileContent(std::string content);

+ bool ParseTraceConfigFileContent(const std::string& content);

bool is_enabled_;

base::trace_event::TraceConfig trace_config_;

« no previous file with comments | « components/test_runner/test_runner.cc ('k') | components/tracing/trace_config_file.cc » ('j') | url/gurl.h » ('J')