Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: components/signin/core/browser/account_tracker_service_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/account_tracker_service_unittest.cc
diff --git a/components/signin/core/browser/account_tracker_service_unittest.cc b/components/signin/core/browser/account_tracker_service_unittest.cc
index 5c0a20e153f295cb3de12296c3d23d2715242d91..eb6751cb46cea84a464a142692c53630c918978e 100644
--- a/components/signin/core/browser/account_tracker_service_unittest.cc
+++ b/components/signin/core/browser/account_tracker_service_unittest.cc
@@ -48,31 +48,31 @@ enum TrackingEventType {
REMOVED,
};
-std::string AccountIdToEmail(const std::string account_id) {
+std::string AccountIdToEmail(const std::string& account_id) {
return account_id + "@gmail.com";
}
-std::string AccountIdToGaiaId(const std::string account_id) {
+std::string AccountIdToGaiaId(const std::string& account_id) {
return "gaia-" + account_id;
}
-std::string AccountIdToFullName(const std::string account_id) {
+std::string AccountIdToFullName(const std::string& account_id) {
return "full-name-" + account_id;
}
-std::string AccountIdToGivenName(const std::string account_id) {
+std::string AccountIdToGivenName(const std::string& account_id) {
return "given-name-" + account_id;
}
-std::string AccountIdToLocale(const std::string account_id) {
+std::string AccountIdToLocale(const std::string& account_id) {
return "locale-" + account_id;
}
-std::string AccountIdToPictureURL(const std::string account_id) {
+std::string AccountIdToPictureURL(const std::string& account_id) {
return "picture_url-" + account_id;
}
-void CheckAccountDetails(const std::string account_id,
+void CheckAccountDetails(const std::string& account_id,
const AccountInfo& info) {
EXPECT_EQ(account_id, info.account_id);
EXPECT_EQ(AccountIdToGaiaId(account_id), info.gaia);

Powered by Google App Engine
This is Rietveld 408576698