Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: components/signin/core/browser/about_signin_internals.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_ABOUT_SIGNIN_INTERNALS_H_ 5 #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_ABOUT_SIGNIN_INTERNALS_H_
6 #define COMPONENTS_SIGNIN_CORE_BROWSER_ABOUT_SIGNIN_INTERNALS_H_ 6 #define COMPONENTS_SIGNIN_CORE_BROWSER_ABOUT_SIGNIN_INTERNALS_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 // Each instance of SigninInternalsUI adds itself as an observer to be 66 // Each instance of SigninInternalsUI adds itself as an observer to be
67 // notified of all updates that AboutSigninInternals receives. 67 // notified of all updates that AboutSigninInternals receives.
68 void AddSigninObserver(Observer* observer); 68 void AddSigninObserver(Observer* observer);
69 void RemoveSigninObserver(Observer* observer); 69 void RemoveSigninObserver(Observer* observer);
70 70
71 // Pulls all signin values that have been persisted in the user prefs. 71 // Pulls all signin values that have been persisted in the user prefs.
72 void RefreshSigninPrefs(); 72 void RefreshSigninPrefs();
73 73
74 void Initialize(SigninClient* client); 74 void Initialize(SigninClient* client);
75 75
76 void OnRefreshTokenReceived(std::string status); 76 void OnRefreshTokenReceived(const std::string& status);
77 void OnAuthenticationResultReceived(std::string status); 77 void OnAuthenticationResultReceived(const std::string& status);
78 78
79 // KeyedService implementation. 79 // KeyedService implementation.
80 void Shutdown() override; 80 void Shutdown() override;
81 81
82 // Returns a dictionary of values in signin_status_ for use in 82 // Returns a dictionary of values in signin_status_ for use in
83 // about:signin-internals. The values are formatted as shown - 83 // about:signin-internals. The values are formatted as shown -
84 // 84 //
85 // { "signin_info" : 85 // { "signin_info" :
86 // [ {"title": "Basic Information", 86 // [ {"title": "Basic Information",
87 // "data": [List of {"label" : "foo-field", "value" : "foo"} elems] 87 // "data": [List of {"label" : "foo-field", "value" : "foo"} elems]
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 // Encapsulates the actual signin and token related values. 216 // Encapsulates the actual signin and token related values.
217 // Most of the values are mirrored in the prefs for persistence. 217 // Most of the values are mirrored in the prefs for persistence.
218 SigninStatus signin_status_; 218 SigninStatus signin_status_;
219 219
220 base::ObserverList<Observer> signin_observers_; 220 base::ObserverList<Observer> signin_observers_;
221 221
222 DISALLOW_COPY_AND_ASSIGN(AboutSigninInternals); 222 DISALLOW_COPY_AND_ASSIGN(AboutSigninInternals);
223 }; 223 };
224 224
225 #endif // COMPONENTS_SIGNIN_CORE_BROWSER_ABOUT_SIGNIN_INTERNALS_H_ 225 #endif // COMPONENTS_SIGNIN_CORE_BROWSER_ABOUT_SIGNIN_INTERNALS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698