chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/session_state_delegate_chromeos_unittest.cc ('k') | chrome/browser/ui/cocoa/profiles/user_manager_mac.mm » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc

diff --git a/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc b/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc

index 098238d8f5a465caa6df2c40c9954f04954b601c..47827b7423952cf358bf9644efaa38744237d115 100644

--- a/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc

+++ b/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc

@@ -83,7 +83,7 @@ class SystemTrayDelegateChromeOSTest : public LoginManagerTest {

~SystemTrayDelegateChromeOSTest() override {}

- void SetupUserProfile(std::string user_name, bool use_24_hour_clock) {

+ void SetupUserProfile(const std::string& user_name, bool use_24_hour_clock) {

const user_manager::User* user =

user_manager::UserManager::Get()->FindUser(user_name);

Profile* profile = ProfileHelper::Get()->GetProfileByUser(user);

« no previous file with comments | « chrome/browser/ui/ash/session_state_delegate_chromeos_unittest.cc ('k') | chrome/browser/ui/cocoa/profiles/user_manager_mac.mm » ('j') | url/gurl.h » ('J')