chrome/browser/ui/ash/session_state_delegate_chromeos_unittest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/session_state_delegate_chromeos_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc ('k') | chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/session_state_delegate_chromeos_unittest.cc

diff --git a/chrome/browser/ui/ash/session_state_delegate_chromeos_unittest.cc b/chrome/browser/ui/ash/session_state_delegate_chromeos_unittest.cc

index 8c3b0776deb6ec6f0f622f1cbeec497e4e6a637f..6d58b793d30c6d7807c8d616cb51cb456a93e8e0 100644

--- a/chrome/browser/ui/ash/session_state_delegate_chromeos_unittest.cc

+++ b/chrome/browser/ui/ash/session_state_delegate_chromeos_unittest.cc

@@ -81,7 +81,7 @@ class SessionStateDelegateChromeOSTest : public testing::Test {

}

// Add and log in a user to the session.

- void UserAddedToSession(std::string user) {

+ void UserAddedToSession(const std::string& user) {

user_manager()->AddUser(user);

user_manager()->LoginUser(user);

}