chrome/browser/safe_browsing/client_side_model_loader.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_model_loader.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/client_side_model_loader.cc

diff --git a/chrome/browser/safe_browsing/client_side_model_loader.cc b/chrome/browser/safe_browsing/client_side_model_loader.cc

index aaa95ba3a46d4591c3834edc291c6cd9165f6b7a..863f820a85a785a63d518265735095b889bb964b 100644

--- a/chrome/browser/safe_browsing/client_side_model_loader.cc

+++ b/chrome/browser/safe_browsing/client_side_model_loader.cc

@@ -93,7 +93,7 @@ ModelLoader::ModelLoader(base::Closure update_renderers_callback,

// For testing only

ModelLoader::ModelLoader(base::Closure update_renderers_callback,

- const std::string model_name)

+ const std::string& model_name)

: name_(model_name),

url_(kClientModelUrlPrefix + name_),

update_renderers_callback_(update_renderers_callback),

« no previous file with comments | « chrome/browser/safe_browsing/client_side_model_loader.h ('k') | chrome/browser/speech/tts_controller_impl.cc » ('j') | url/gurl.h » ('J')