Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: chrome/browser/safe_browsing/client_side_model_loader.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/client_side_model_loader.h" 5 #include "chrome/browser/safe_browsing/client_side_model_loader.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 : name_(FillInModelName(is_extended_reporting, GetModelNumber())), 86 : name_(FillInModelName(is_extended_reporting, GetModelNumber())),
87 url_(kClientModelUrlPrefix + name_), 87 url_(kClientModelUrlPrefix + name_),
88 update_renderers_callback_(update_renderers_callback), 88 update_renderers_callback_(update_renderers_callback),
89 request_context_getter_(request_context_getter), 89 request_context_getter_(request_context_getter),
90 weak_factory_(this) { 90 weak_factory_(this) {
91 DCHECK(url_.is_valid()); 91 DCHECK(url_.is_valid());
92 } 92 }
93 93
94 // For testing only 94 // For testing only
95 ModelLoader::ModelLoader(base::Closure update_renderers_callback, 95 ModelLoader::ModelLoader(base::Closure update_renderers_callback,
96 const std::string model_name) 96 const std::string& model_name)
97 : name_(model_name), 97 : name_(model_name),
98 url_(kClientModelUrlPrefix + name_), 98 url_(kClientModelUrlPrefix + name_),
99 update_renderers_callback_(update_renderers_callback), 99 update_renderers_callback_(update_renderers_callback),
100 request_context_getter_(NULL), 100 request_context_getter_(NULL),
101 weak_factory_(this) { 101 weak_factory_(this) {
102 DCHECK(url_.is_valid()); 102 DCHECK(url_.is_valid());
103 } 103 }
104 104
105 ModelLoader::~ModelLoader() { 105 ModelLoader::~ModelLoader() {
106 } 106 }
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 } 198 }
199 199
200 void ModelLoader::CancelFetcher() { 200 void ModelLoader::CancelFetcher() {
201 // Invalidate any scheduled request. 201 // Invalidate any scheduled request.
202 weak_factory_.InvalidateWeakPtrs(); 202 weak_factory_.InvalidateWeakPtrs();
203 // Cancel any request in progress. 203 // Cancel any request in progress.
204 fetcher_.reset(); 204 fetcher_.reset();
205 } 205 }
206 206
207 } // namespace safe_browsing 207 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698