Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: chrome/browser/net/sdch_browsertest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/sdch_browsertest.cc
diff --git a/chrome/browser/net/sdch_browsertest.cc b/chrome/browser/net/sdch_browsertest.cc
index 9c93d6b841dda2a74a62edc80a7e47aa3af5d16e..406aeca6ba572bf911cf1ef6492f300e0bb00abc 100644
--- a/chrome/browser/net/sdch_browsertest.cc
+++ b/chrome/browser/net/sdch_browsertest.cc
@@ -131,9 +131,8 @@ void SafeBase64Encode(const std::string& input_value, std::string* output) {
class SdchResponseHandler {
public:
// Do initial preparation so that SDCH requests can be handled.
- explicit SdchResponseHandler(std::string domain)
- : cache_sdch_response_(false),
- weak_ptr_factory_(this) {
+ explicit SdchResponseHandler(const std::string& domain)
+ : cache_sdch_response_(false), weak_ptr_factory_(this) {
// Dictionary
sdch_dictionary_contents_ = "Domain: ";
sdch_dictionary_contents_ += domain;

Powered by Google App Engine
This is Rietveld 408576698