Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc
diff --git a/chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc b/chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc
index b7d7f4c0230d14a9ddfd86ed76959825a9e1b1c2..6de3fa624d7f8ca336724e79719d76858423235e 100644
--- a/chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc
+++ b/chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc
@@ -34,7 +34,7 @@ class NaClGdbTest : public PPAPINaClNewlibTest {
command_line->AppendSwitchPath(switches::kNaClGdbScript, script_);
}
- void RunWithNaClGdb(std::string test_name) {
+ void RunWithNaClGdb(const std::string& test_name) {
base::FilePath mock_nacl_gdb_file;
scoped_ptr<base::Environment> env(base::Environment::Create());
std::string content;

Powered by Google App Engine
This is Rietveld 408576698