chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api_unittest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_actions.h ('k') | chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api_unittest.cc

diff --git a/chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api_unittest.cc b/chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api_unittest.cc

index 3f66ab383b7f555cbb6dc646c393aa0156e2b8b9..6e1150cba2b3c690eb0fd6f0b413ecf3d11016a6 100644

--- a/chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api_unittest.cc

+++ b/chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api_unittest.cc

@@ -45,7 +45,8 @@ class CryptoTokenPrivateApiTest : public extensions::ExtensionApiUnittest {

return true;

}

- bool GetCanOriginAssertAppIdResult(std::string origin, std::string appId) {

+ bool GetCanOriginAssertAppIdResult(const std::string& origin,

+ const std::string& appId) {

scoped_refptr<api::CryptotokenPrivateCanOriginAssertAppIdFunction> function(

new api::CryptotokenPrivateCanOriginAssertAppIdFunction());

function->set_has_callback(true);