chrome/browser/extensions/activity_log/activity_actions.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/activity_actions.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc ('k') | chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api_unittest.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/activity_actions.h

diff --git a/chrome/browser/extensions/activity_log/activity_actions.h b/chrome/browser/extensions/activity_log/activity_actions.h

index 277ca3e194c9855b78527801e2cd5896f21ac660..902b550286a8ec4853a172676ef6968e0e427132 100644

--- a/chrome/browser/extensions/activity_log/activity_actions.h

+++ b/chrome/browser/extensions/activity_log/activity_actions.h

@@ -67,7 +67,7 @@ class Action : public base::RefCountedThreadSafe<Action> {

// The specific API call used or accessed, for example "chrome.tabs.get".

const std::string& api_name() const { return api_name_; }

- void set_api_name(const std::string api_name) { api_name_ = api_name; }

+ void set_api_name(const std::string& api_name) { api_name_ = api_name; }

// Any applicable arguments. This might be null to indicate no data

// available (a distinct condition from an empty argument list).