cc/output/shader.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/shader.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/shader.h

diff --git a/cc/output/shader.h b/cc/output/shader.h

index 326eb67b534fc9c39566d154ca4bc8ee2852ab8a..448ff07a8b28aa6958eefb2f1777ef425c28fb85 100644

--- a/cc/output/shader.h

+++ b/cc/output/shader.h

@@ -371,7 +371,7 @@ class FragmentTexBlendMode {

protected:

FragmentTexBlendMode();

- std::string SetBlendModeFunctions(std::string shader_string) const;

+ std::string SetBlendModeFunctions(const std::string& shader_string) const;

int backdrop_location_;

int original_backdrop_location_;

« no previous file with comments | « base/logging.h ('k') | cc/output/shader.cc » ('j') | url/gurl.h » ('J')