cc/output/shader.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/shader.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/shader.cc

diff --git a/cc/output/shader.cc b/cc/output/shader.cc

index 4a877ae859f6e6da9bcd4d759881fdfe78e45f00..a4ee1bbfc6baa38661c4b2cfb3e08800a880c653 100644

--- a/cc/output/shader.cc

+++ b/cc/output/shader.cc

@@ -772,7 +772,7 @@ FragmentTexBlendMode::FragmentTexBlendMode()

}

std::string FragmentTexBlendMode::SetBlendModeFunctions(

- std::string shader_string) const {

+ const std::string& shader_string) const {

if (shader_string.find("ApplyBlendMode") == std::string::npos)

return shader_string;

« no previous file with comments | « cc/output/shader.h ('k') | chrome/browser/android/history_report/delta_file_backend_leveldb.cc » ('j') | url/gurl.h » ('J')