Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2015)

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 1349613003: [Extensions] Un-refcount PermissionSet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index c8cee2bda9dd81dc1f266cde77ba227544bb1dc1..70a9234f6aeceeee71bf1598b10a004ad36a6528 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -297,11 +297,11 @@ CrxInstallError CrxInstaller::AllowInstall(const Extension* extension) {
extension->id(),
&error);
if (error.empty()) {
- scoped_refptr<const PermissionSet> expected_permissions =
+ const PermissionSet* expected_permissions =
dummy_extension->permissions_data()->active_permissions();
valid = !(PermissionMessageProvider::Get()->IsPrivilegeIncrease(
- expected_permissions.get(),
- extension->permissions_data()->active_permissions().get(),
+ expected_permissions,
+ extension->permissions_data()->active_permissions(),
extension->GetType()));
}
}
@@ -798,6 +798,8 @@ void CrxInstaller::ReportSuccessFromUIThread() {
if (!service_weak_.get() || service_weak_->browser_terminating())
return;
+ extension()->permissions_data()->LockToThread();
+
if (!update_from_settings_page_) {
// If there is a client, tell the client about installation.
if (client_)

Powered by Google App Engine
This is Rietveld 408576698