[Extensions] Un-refcount PermissionSet

chrome/browser/extensions/crx_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/crx_installer.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 279 matching lines @@
           WebstoreInstaller::MANIFEST_CHECK_LEVEL_LOOSE) {
         std::string error;
         scoped_refptr<Extension> dummy_extension =
             Extension::Create(base::FilePath(),
                               install_source_,
                               *expected_manifest_->value(),
                               creation_flags_,
                               extension->id(),
                               &error);
         if (error.empty()) {
-          scoped_refptr<const PermissionSet> expected_permissions =
+          const PermissionSet* expected_permissions =
               dummy_extension->permissions_data()->active_permissions();
           valid = !(PermissionMessageProvider::Get()->IsPrivilegeIncrease(
-              expected_permissions.get(),
-              extension->permissions_data()->active_permissions().get(),
+              expected_permissions,
+              extension->permissions_data()->active_permissions(),
               extension->GetType()));
         }
       }
     }
 
     if (!valid)
       return CrxInstallError(
           l10n_util::GetStringUTF16(IDS_EXTENSION_MANIFEST_INVALID));
   }
 
@@ skipping 476 matching lines @@
   // Delete temporary files.
   CleanupTempFiles();
 }
 
 void CrxInstaller::ReportSuccessFromUIThread() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
   if (!service_weak_.get() || service_weak_->browser_terminating())
     return;
 
+  extension()->permissions_data()->LockToThread();
+
   if (!update_from_settings_page_) {
     // If there is a client, tell the client about installation.
     if (client_)
       client_->OnInstallSuccess(extension(), install_icon_.get());
 
     // We update the extension's granted permissions if the user already
     // approved the install (client_ is non NULL), or we are allowed to install
     // this silently.
     if ((client_ || allow_silent_install_) &&
         grant_permissions_ &&
@@ skipping 90 matching lines @@
   if (!prefs->DidExtensionEscalatePermissions(extension()->id()))
     return;
 
   if (client_) {
     AddRef();  // Balanced in InstallUIProceed() and InstallUIAbort().
     client_->ConfirmReEnable(this, extension());
   }
 }
 
 }  // namespace extensions