Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7306)

Unified Diff: chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc

Issue 1349613003: [Extensions] Un-refcount PermissionSet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc
diff --git a/chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc b/chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc
index a4ff23751680aaf5da580416a87fdecfc2063764..815cfc556cf2d7745a933c38438e30bf81cf3ccc 100644
--- a/chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc
+++ b/chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc
@@ -35,21 +35,19 @@ class ChromePermissionMessageProviderUnittest : public testing::Test {
protected:
PermissionMessages GetMessages(const APIPermissionSet& permissions,
Manifest::Type type) {
- scoped_refptr<const PermissionSet> permission_set = new PermissionSet(
- permissions, ManifestPermissionSet(), URLPatternSet(), URLPatternSet());
+ PermissionSet permission_set(permissions, ManifestPermissionSet(),
+ URLPatternSet(), URLPatternSet());
return message_provider_->GetPermissionMessages(
- message_provider_->GetAllPermissionIDs(permission_set.get(), type));
+ message_provider_->GetAllPermissionIDs(&permission_set, type));
}
bool IsPrivilegeIncrease(const APIPermissionSet& old_permissions,
const APIPermissionSet& new_permissions) {
- scoped_refptr<PermissionSet> old_set(
- new PermissionSet(old_permissions, ManifestPermissionSet(),
- URLPatternSet(), URLPatternSet()));
- scoped_refptr<PermissionSet> new_set(
- new PermissionSet(new_permissions, ManifestPermissionSet(),
- URLPatternSet(), URLPatternSet()));
- return message_provider_->IsPrivilegeIncrease(old_set.get(), new_set.get(),
+ PermissionSet old_set(old_permissions, ManifestPermissionSet(),
+ URLPatternSet(), URLPatternSet());
+ PermissionSet new_set(new_permissions, ManifestPermissionSet(),
+ URLPatternSet(), URLPatternSet());
+ return message_provider_->IsPrivilegeIncrease(&old_set, &new_set,
Manifest::TYPE_EXTENSION);
}

Powered by Google App Engine
This is Rietveld 408576698