chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc - Issue 1349613003: [Extensions] Un-refcount PermissionSet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc

Issue 1349613003: [Extensions] Un-refcount PermissionSet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/themes/theme_syncable_service_unittest.cc ('k') | chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc

diff --git a/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc b/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc

index 52516c3952944e9ee0dcad111623e7fe9e545dd2..5e7f279eaa32d0a08e71ef0acaaf2dc8b363e7fa 100644

--- a/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc

+++ b/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc

@@ -212,16 +212,17 @@ TEST_F(ProfileSigninConfirmationHelperTest, PromptForNewProfile_Extensions) {

CreateExtension("web store",

extensions::kWebStoreAppId,

extensions::Manifest::COMPONENT);

- extensions::ExtensionPrefs::Get(profile_.get())->AddGrantedPermissions(

- webstore->id(), make_scoped_refptr(new extensions::PermissionSet).get());

+ extensions::PermissionSet empty_permissions;

+ extensions::ExtensionPrefs::Get(profile_.get())

+ ->AddGrantedPermissions(webstore->id(), &empty_permissions);

extensions->AddExtension(webstore.get());

EXPECT_FALSE(GetCallbackResult(

base::Bind(&ui::CheckShouldPromptForNewProfile, profile_.get())));

scoped_refptr<extensions::Extension> extension =

CreateExtension("foo", std::string(), extensions::Manifest::INTERNAL);

- extensions::ExtensionPrefs::Get(profile_.get())->AddGrantedPermissions(

- extension->id(), make_scoped_refptr(new extensions::PermissionSet).get());

+ extensions::ExtensionPrefs::Get(profile_.get())

+ ->AddGrantedPermissions(extension->id(), &empty_permissions);

extensions->AddExtension(extension.get());

EXPECT_TRUE(GetCallbackResult(

base::Bind(&ui::CheckShouldPromptForNewProfile, profile_.get())));