Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2509)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.html

Issue 1349543006: [MD settings] adding homepage url input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@appearance7b
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_page.html
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.html b/chrome/browser/resources/settings/appearance_page/appearance_page.html
index 6bc62a787f965311494a44c5941f1c29c1e98c01..bf8be5c83736500d0fa86d2ab6b26ce95358fede 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.html
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.html
@@ -1,8 +1,9 @@
<link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
-<link rel="import" href="chrome://md-settings/checkbox/checkbox.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/paper-radio-button.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-group/paper-radio-group.html">
+<link rel="import" href="chrome://md-settings/checkbox/checkbox.html">
<dom-module id="cr-settings-appearance-page">
<link rel="import" type="css"
@@ -34,6 +35,14 @@
<paper-radio-button
name="false">[[i18n_.openThisPage]]</paper-radio-button>
</paper-radio-group>
+ <div class="radio-extended">
+ <paper-input no-label-float
+ value="{{homepage_}}"
Dan Beam 2015/09/17 17:13:48 why can't this just be: value="{{prefs.homepage.va
dschuyler 2015/09/17 18:02:41 We can do that :) This next patch uses prefs.home
dschuyler 2015/09/17 18:28:36 Also, there's a DCHECK about the url being valid t
+ label="[[i18n_.onStartupEnterUrl]]">
+ </paper-input>
Dan Beam 2015/09/17 17:13:48 this can be 2 lines instead of 4
dschuyler 2015/09/17 18:02:41 Done.
+ <paper-button
+ on-tap="onSetHomepageTap_">[[i18n_.changeHomePage]]</paper-button>
+ </div>
</div>
</template>
<cr-settings-checkbox pref="{{prefs.bookmark_bar.show_on_all_tabs}}"

Powered by Google App Engine
This is Rietveld 408576698